Add Denmark country data and public holidays#169
Open
hjertis wants to merge 12 commits into
Open
Conversation
Introduce Denmark (DK) into the dataset by adding country and language registry entries, a new DK subdivision file with the five regions, and national public holiday records for 2025-2035 with Danish and English names.
There was a problem hiding this comment.
Pull request overview
This pull request introduces Denmark (DK) to the dataset by registering Denmark in the country/language registries, adding a DK subdivision listing, and adding national public holidays for 2025–2035 with Danish/English names.
Changes:
- Added a Denmark entry to
src/countries.csv. - Added a Danish language entry to
src/languages.csv. - Added DK subdivisions data and DK public holiday records (2025–2035).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/languages.csv | Adds a new language registry entry intended for Danish. |
| src/countries.csv | Adds Denmark to the country registry and declares its official language(s). |
| src/dk/subdivision.csv | Adds DK subdivision data (currently not aligned with existing subdivision file conventions). |
| src/dk/holidays/holidays.public.csv | Adds Denmark national public holidays for 2025–2035 with DA/EN names. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Updates `countries.csv` to use `DA` instead of `DK` for Denmark, and renames `src/dk/subdivision.csv` to `src/dk/subdivisions.csv` to match the expected plural filename convention.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Adds Denmark to the README country coverage list and updates DK public holiday records to include German (DE) translations alongside Danish and English names for 2025–2035. It also migrates `src/dk/subdivisions.csv` to the standardized subdivision schema (country/ISO codes, multilingual category/name fields, official language, and parent columns) for consistency with the repository format.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
- Fix German spelling: 'Gruendonnerstag' → 'Gründonnerstag' in public holidays - Add German translations for all 5 Danish regions in subdivisions - Update README to reflect Denmark has only public holidays (not school holidays)
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Reorder the Denmark subdivision records in `src/dk/subdivisions.csv` so the region codes are listed in ascending order.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce Denmark (DK) into the dataset by adding country and language registry entries, a new DK subdivision file with the five regions, and national public holiday records for 2025-2035 with Danish, English and German names.